我在用值填充2d数组时遇到问题。很多例子都有一个静态数组，但是，我使用for循环来填充它
- 第二个参数是d，假设用户输入3，则：
- 创建一个3x3阵列
- 数组将存储从8到0的所有值
- 它将阵列打印到终端，如下所示：
8 7 6
5 4 3
2 1 0
- 如果用户输入4，则会创建一个4x4阵列
- 它会将此打印到控制台：
15 14 13 12
11 10 9 8
7 6 5 4
3 2 1 0
/**
* fifteen.c
*
* Computer Science 50
* Problem Set 3
*
* Implements the Game of Fifteen (generalized to d x d).
*
* Usage: ./fifteen d
*
* whereby the board's dimensions are to be d x d,
* where d must be in [MIN,MAX]
*
* Note that usleep is obsolete, but it offers more granularity than
* sleep and is simpler to use than nanosleep; `man usleep` for more.
*/
#define _XOPEN_SOURCE 500
#include <cs50.h>
#include <stdio.h>
#include <stdlib.h>
#include <unistd.h>
// board's minimal dimension
#define MIN 3
// board's maximal dimension
#define MAX 9
// board, whereby board[i][j] represents row i and column j
int board[MAX][MAX];
// board's dimension
int d;
// prototypes
void clear(void);
void greet(void);
void init(void);
void draw(void);
bool move(int tile);
bool won(void);
void save(void);
int main(int argc, string argv[])
{
// greet player
greet();
// ensure proper usage
if (argc != 2)
{
printf("Usage: ./fifteen [3-9]n");
return 1;
}
// ensure valid dimensions
d = atoi(argv[1]);
if (d < MIN || d > MAX)
{
printf("Board must be between %i x %i and %i x %i, inclusive.n",
MIN, MIN, MAX, MAX);
return 2;
}
// initialize the board
init();
// accept moves until game is won
while (true)
{
// clear the screen
//clear();
// draw the current state of the board
draw();
// saves the current state of the board (for testing)
save();
// check for win
if (won())
{
printf("ftw!n");
break;
}
// prompt for move
printf("Tile to move: ");
int tile = GetInt();
// move if possible, else report illegality
if (!move(tile))
{
printf("nIllegal move.n");
usleep(500000);
}
// sleep for animation's sake
usleep(500000);
}
// that's all folks
return 0;
}
/**
* Clears screen using ANSI escape sequences.
*/
void clear(void)
{
printf(" 33[2J");
printf(" 33[%d;%dH", 0, 0);
}
/**
* Greets player.
*/
void greet(void)
{
clear();
printf("GAME OF FIFTEENn");
//usleep(2000000);
}
/**
* Initializes the game's board with tiles numbered 1 through d*d - 1,
* (i.e., fills board with values but does not actually print them),
* whereby board[i][j] represents row i and column j.
*/
void init(void)
{
// TODO
// represent board in 2D integer array
// int board [MAX][MAX]
// int d
// size of board. d <= MAX
// board [i][j] represents the element at row i and col j
// starts in descending order
// if number of tiles is odd, swap 2 and 1
/**
take d and print board with dxd dimensions
loop through x to go up to d-1 (i.e. 4x4 board = 16, values will be 15 to 1)
*/
//initialize array
int numbers[d][d];
//print the array size
printf("Array size:%dn", d);
//variable i, j
int i;
int j;
// board's numbering
int s = (d*2)-1;
int countarray[d];
int count;
for (count = s; count > 0; count--)
{
countarray[count]=count;
}
printf("Start of board's numbering: %dn", s);
//assign values to array with loop
for (i = 0; i < d; i++)
{
for ( j = 0; j < d; j++)
{
numbers[i][j] = 0;
numbers[i][j] = countarray[count];
printf("numbers[%d][%d] = %d n", i, j, numbers[i][j]);
}
}
//print a number from the array
printf("The 4th integer of the array is: %dn", numbers[3][3]);
printf("Value of d: %dn", d);
for (int x = 0; x < d; x++){
for (int y = 0; y < d; y++){
// print the array value [ x, y ]
printf("%d", numbers[x][y]);
printf(" ");
}
// print a new line here
printf("n");
}
}
/**
* Prints the board in its current state.
*/
void draw(void)
{
// TODO
// print current state of the board
// print a blank space fore single digit #s
// printf("%2d", board[i][j]);
/**
for each row
for each value in row
print value and space
print new line
*/
}
/**
* If tile borders empty space, moves tile and returns true, else
* returns false.
*/
bool move(int tile)
{
// TODO
return false;
}
/**
* Returns true if game is won (i.e., board is in winning configuration),
* else false.
*/
bool won(void)
{
// TODO
return false;
}
/**
* Saves the current state of the board to disk (for testing).
*/
void save(void)
{
// log
const string log = "log.txt";
// delete existing log, if any, before first save
static bool saved = false;
if (!saved)
{
unlink(log);
saved = true;
}
// open log
FILE* p = fopen(log, "a");
if (p == NULL)
{
return;
}
// log board
fprintf(p, "{");
for (int i = 0; i < d; i++)
{
fprintf(p, "{");
for (int j = 0; j < d; j++)
{
fprintf(p, "%i", board[i][j]);
if (j < d - 1)
{
fprintf(p, ",");
}
}
fprintf(p, "}");
if (i < d - 1)
{
fprintf(p, ",");
}
}
fprintf(p, "}n");
// close log
fclose(p);
}
参数为3时，它会正确地将3x3数组打印到终端。但是，数组中的所有9个值都是134517847。如果有任何帮助，我将不胜感激，谢谢。
在内部循环中，错误的变量x正在递增。应该是y++而不是x++。
for (int x = 0; x < d; x++){
for (int y = 0; y < d; x++){
^^^
循环需要迭代count==0。将条件从>更改为>=。
for (count = s; count >= 0; count--)
{
countarray[count]=count;
}
s初始化为
int s = (d*2)-1;
但这不应该是d*d-1吗？
int s = (d*d)-1;
在初始化数字数组的循环中，count既不初始化也不递减。我猜你需要这样的东西：
count = s;
for (i = 0; i < d; i++)
{
for ( j = 0; j < d; j++)
{
numbers[i][j] = countarray[count--];
printf("numbers[%d][%d] = %d n", i, j, numbers[i][j]);
}
}
除了y的循环递增x之外，您没有将数组中的值设置为任何有意义的值。
numbers[i][j] = countarray[count];
CCD_ 3在这个循环中实际上从未改变。您应该只循环到最大值并以数学方式计算行和列，或者将变量分配给最大值并在分配给数组时递减。
最简单的方法是将二维数组视为常规数组
init(d, &board[0][0]);
init()功能
void init(int d, int *array) {
int dd = d * d;
do *array++ = --dd; while (dd > 0);
}