c-尝试从文本文件中读取数据，从中生成结构，并将字段打印到stdout

Question

我从文件中读取然后创建结构似乎没有问题，但打印结构会导致分段错误。

员工定义

struct _Employee {
  int salary; // Monthly salary in UK pounds sterling
  char *name; // Pointer to character string holding name of employee.
  char* department;           // MUST be dynamically allocated from the heap.
};
typedef struct _Employee Employee;

从文件读取的函数

Employee* readfile(FILE* file) {
  Employee* newemployee;
  newemployee = malloc(sizeof(Employee));
  char tempsalary[10];
  int salary;
  char name[20];
  char dept[20];
  char* names = malloc(sizeof(name));
  char* depts = malloc(sizeof(dept));
  char* status; // Returned by fgets(). Will be NULL at EOF

    status = fgets(names, sizeof(name), file);
    if (status == NULL)
      return NULL;
    else {
      newemployee->name = strdup(status);

    fgets(tempsalary, sizeof(name), file);
    sscanf(tempsalary, "%d", &salary);
    newemployee->salary = salary;
    fgets(depts, sizeof(dept), file);
    newemployee->department = strdup(depts);
    return newemployee;
    }
}

函数打印由readfile生成的结构。

void printEmployee(Employee *employee) {
      fprintf(stdout, "Name = %sSalary = %dnDepartment = %snn", // SEGFAULT HERE
          employee->name, employee->salary, employee->department);
}

主程序

int main() {
  FILE* file;
  file = fopen ("stest2.txt", "r");
  Employee* employees[max_employees];
  int i;
  int c;
  Employee* temp;
    for (i = 0; i < max_employees; i++) {
    employees[i] = readfile(file)   
    printEmployee(employees[i]);
    }
  return 0;
}

Answer 1

readfile（）在fgets错误的情况下可以返回NULL。这个案子基本上没有得到处理。作为一个原始的建议：

    for (i = 0; i < max_employees; i++) {
        employees[i] = readfile(file);
        if(NULL != employees[i])
        {   
            printEmployee(employees[i]);
        }
        else
        {
            printf("Error reading file");
        }

Answer 2

我将不得不使用fgets（）在堆栈上涂鸦。更改此项：

 fgets(tempsalary, sizeof(name), file);

到此：

 fgets(tempsalary, sizeof(tempsalary), file);

可能不是问题，但这肯定是"一个"问题。