如何优化这个有bug的逻辑?

Question

我正在处理这些4个字段(每个字段有不同的名称&功能)。有没有办法让这更容易管理?

<!--- Lifeguard Instructor --->
<!--- Is the date defined? --->
<cfif len(Trim(form.lifeguardInstrcutorExp)) EQ 0>
    <cfinvokeargument name="lifeguardInstrcutorExp" 
        value="#defaultDate#">
<cfelse>
    <cfinvokeargument name="lifeguardInstrcutorExp" 
        value="#CreateODBCDate(Form.lifeguardInstrcutorExp)#">
</cfif>
<!--- Is a Company defined? --->
<cfif len(Trim(form.lifeguardInstrcutorCompany)) EQ 0>
    <cfinvokeargument name="lifeguardInstrcutorCompany" value="">
<cfelse>
    <cfinvokeargument name="lifeguardInstrcutorCompany" 
        value="#Trim(Form.lifeguardInstrcutorCompany)#">
</cfif>
<!--- Has a file been specificed? --->
<cfif not len(Trim(form.lifeguardInstrcutorImage)) EQ 0>
    <cffile action="upload" accept="#defaultFileAccepted#" 
        filefield="lifeguardInstrcutorImage" 
        destination="#destination#" 
        nameConflict="makeUnique">
    <cfinvokeargument name="lifeguardInstrcutorImage" 
        value="#pathOfFile##cffile.serverFile#">
<cfelse>
</cfif>
<!--- Do We have a hard copy? --->
<cfinvokeargument name="lifeguardInstrcutorOnFile" 
    value="#Trim(form.lifeguardInstrcutorOnFile)#">

Answer 1

我会有你调用的函数有默认参数的参数，然后传递的形式作为参数集合。

功能:

<cffunction name="myFunctionUsingForm">
        <cfargument name"lifeguardInstructorExp" type="string" default="#defaultDate#" />
        <cfargument name"lifeguardInstrcutorCompany" type="string" default="" />
        <cfargument name"lifeguardInstrcutorImage" type="any" default="" />
        <cfargument name"lifeguardInstrcutorOnFile" type="boolean" default="false" />

调用:

<cfset myFunctionUsingForm(argumentCollection=form) />