我正在努力将遗留数据库迁移到我的Rails应用程序(3.2.3(中。原始数据库带有相当多的长 sql 查询报告。现在,我想做的是使用 Rails 应用程序中的 sql 查询,然后一个接一个地(在时间允许的情况下(将 sql 查询交换为"适当的"Rails 查询。
我有一个临床模型,控制器具有以下代码:
@clinical_income_by_year = Clinical.find_all_by_sql(SELECT date_format(c.transactiondate,'%Y') as Year,
date_format(c.transactiondate,'%b') as Month,
sum(c.LineBalance) as "Income"
FROM clinical c
WHERE c.Payments = 0 AND c.LineBalance <> 0
AND c.analysiscode <> 213
GROUP BY c.MonthYear;)
但是,当我运行该代码时,我遇到了一些与格式有关的错误。
Started GET "/clinicals" for 127.0.0.1 at 2012-04-29 18:00:45 +0100
SyntaxError (/Users/dannymcclelland/Projects/premvet/app/controllers/clinicals_controller.rb:6: syntax error, unexpected tIDENTIFIER, expecting ')'
...rmat(c.transactiondate,'%Y') as Year,
... ^
/Users/dannymcclelland/Projects/premvet/app/controllers/clinicals_controller.rb:7: syntax error, unexpected tIDENTIFIER, expecting keyword_end
...rmat(c.transactiondate,'%b') as Month,
... ^
/Users/dannymcclelland/Projects/premvet/app/controllers/clinicals_controller.rb:8: syntax error, unexpected tIDENTIFIER, expecting keyword_end
... sum(c.LineBalance) as "Income"
... ^
/Users/dannymcclelland/Projects/premvet/app/controllers/clinicals_controller.rb:10: syntax error, unexpected tCONSTANT, expecting keyword_end
... WHERE c.Payments = 0 AND c.LineBalance <> 0
... ^
/Users/dannymcclelland/Projects/premvet/app/controllers/clinicals_controller.rb:10: syntax error, unexpected '>'
...yments = 0 AND c.LineBalance <> 0
... ^
/Users/dannymcclelland/Projects/premvet/app/controllers/clinicals_controller.rb:11: syntax error, unexpected '>'
... AND c.analysiscode <> 213
... ^
在将 sql 查询导入控制器之前,我应该对它执行哪些操作?尽管查询可能存在问题(它是很久以前编写的(,但当直接在数据库中运行时,它确实按预期工作。它返回如下数组:
----------------------------------------------
| Year | Month | Income |
----------------------------------------------
----------------------------------------------
| 2012 | January | 20,000 |
| 2012 | February | 20,000 |
| 2012 | March | 20,000 |
| 2012 | April | 20,000 |
----------------------------------------------
etc..
任何帮助,建议或一般指示将不胜感激!
我正在通读 http://guides.rubyonrails.org/active_record_querying.html 尝试将sql查询转换为正确的Rails查询。
到目前为止,我已经匹配了倒数第二行:
AND c.analysiscode <> 213
跟
@clinical_income_by_year = Clinical.where("AnalysisCode != 213")
婴儿步骤!
更新
多亏了 Rails 指南站点,我现在已经对过滤进行了排序,但我被困在 sql 查询的分组和求和部分。到目前为止,我有以下内容:
@clinical_income_by_year = Clinical.where("AnalysisCode != 213 AND Payments != 0 AND LineBalance != 0").page(params[:page]).per_page(15)
我正在努力构建以下两行sql查询:
sum(c.LineBalance) as "Income"
和
GROUP BY c.MonthYear;)
我的视图代码如下所示:
<% @clinical_income_by_year.each do |clinical| %>
<tr>
<td><%= clinical.TransactionDate.strftime("%Y") %></td>
<td><%= clinical.TransactionDate.strftime("%B") %></td>
<td><%= Clinical.sum(:LineBalance) %></td>
</tr>
<% end %>
</table>
<%= will_paginate @clinical_income_by_year %>
Ruby 解析器不懂 SQL,需要使用一个字符串:
@clinical_income_by_year = Clinical.find_by_sql(%q{ ... })
我建议为此使用 %q
或 %Q
(如果您需要插值(,这样您就不必担心嵌入式引号。您还应该将其移动到模型中的类方法中,以防止您的控制器担心与其无关的事情,这也将使您能够轻松访问connection.quote
和朋友,以便您可以正确使用字符串插值:
find_by_sql(%Q{
select ...
from ...
where x = #{connection.quote(some_string)}
})
此外,SQL 中的分号:
GROUP BY c.MonthYear;})
没有必要。有些数据库会让它通过,但无论如何你都应该摆脱它。
根据您的数据库,标识符(表名、列名等(应该不区分大小写(除非某个可恶的人在创建它们时引用了它们(,因此您可能能够使用小写列名来更好地适应 Rails。
另请注意,某些数据库不喜欢 GROUP BY,因为 SELECT 中的列未聚合或分组,因此对于每个组使用哪个c.transactiondate
存在歧义。
查询的更"Railsy"版本如下所示:
@c = Clinical.select(%q{date_format(transactiondate, '%Y') as year, date_format(transactiondate, '%b') as month, sum(LineBalance) as income})
.where(:payments => 0)
.where('linebalance <> ?', 0)
.where('analysiscode <> ?', 213)
.group(:monthyear)
然后你可以做这样的事情:
@c.each do |c|
puts c.year
puts c.month
puts c.income
end
以访问结果。你也可以通过将日期重整推送到 Ruby 中来简化一点:
@c = Clinical.select(%q{c.transactiondate, sum(c.LineBalance) as income})
.where(:payments => 0)
.where('linebalance <> ?', 0)
.where('analysiscode <> ?', 213)
.group(:monthyear)
然后在 Ruby 中拉开c.transactiondate
,而不是调用 c.year
和 c.month
。