我用来突出显示怪物的方法有问题(我只是使用精灵(,但问题是,它不会突出显示每个怪物,而只会突出显示最后一个添加的怪物。
以下是突出显示的方法:
public void highlightMonsters(){
while (mStack.size()!=0){
if (mStack.peek().toString().equals("1")) {
monsterTopLeft.setVisible(!visibility);
monsterTopLeftColored.setVisible(visibility);
monsterTopLeftColored.registerUpdateHandler(changeColorsMonster1);
mReverseStack.push(mStack.pop());
monsterTopLeft.registerUpdateHandler(cakaj);
}
else if(mStack.peek().toString().equals("2")) {
monsterTopRight.setVisible(!visibility);
monsterTopRightColored.setVisible(visibility);
monsterTopRightColored.registerUpdateHandler(changeColorsMonster2);
mReverseStack.push(mStack.pop());
monsterTopRight.registerUpdateHandler(cakaj);
}
else if(mStack.peek().toString().equals("3")) {
monsterBottomLeft.setVisible(!visibility);
monsterBottomLeftColored.setVisible(visibility);
monsterBottomLeftColored.registerUpdateHandler(changeColorsMonster3);
mReverseStack.push(mStack.pop());
monsterBottomLeft.registerUpdateHandler(cakaj);
}
else if (mStack.peek().toString().equals("4")){
monsterBottomRight.setVisible(!visibility);
monsterBottomRightColored.setVisible(visibility);
monsterBottomRightColored.registerUpdateHandler(changeColorsMonster4);
mReverseStack.push(mStack.pop());
monsterBottomRight.registerUpdateHandler(cakaj);
}
}
}
这是主循环
public void mainLoop() {
cislo = generateNumber();
testText.setText(String.valueOf(cislo));
mReverseStack.push(new Integer(cislo)); //debugging purposes
//cisla su v mReverseStack
reverseNumbersInStack2();
//prehodime do mStack
highlightMonsters();
//vysvietime a zaroven prehodime do mReverseStack
reverseNumbersInStack2();
//prehodime do mStack
}
我不确定你的代码是否适合你的目的,但如果你想让你的代码工作,你不要偷看,你弹出。并且每个循环一次 - 如果你不覆盖一个数字,在你的 if 语句中这样做可能会导致无限循环。如果代码的其他部分没有错误,这样的事情应该可以工作:
public void highlightMonsters(){
while (mStack.size()!=0){
String monsterString = mStack.pop().toString();
switch(monsterString)
case "1" : {
monsterTopLeft.setVisible(!visibility);
monsterTopLeftColored.setVisible(visibility);
monsterTopLeftColored.registerUpdateHandler(changeColorsMonster1);
monsterTopLeft.registerUpdateHandler(cakaj);
break;
}
case "2" : {
monsterTopRight.setVisible(!visibility);
monsterTopRightColored.setVisible(visibility);
monsterTopRightColored.registerUpdateHandler(changeColorsMonster2);
monsterTopRight.registerUpdateHandler(cakaj);
break;
}
case "3" : {
monsterBottomLeft.setVisible(!visibility);
monsterBottomLeftColored.setVisible(visibility);
monsterBottomLeftColored.registerUpdateHandler(changeColorsMonster3);
monsterBottomLeft.registerUpdateHandler(cakaj);
break;
}
case "4" : (mStack.peek().toString().equals("4")){
monsterBottomRight.setVisible(!visibility);
monsterBottomRightColored.setVisible(visibility);
monsterBottomRightColored.registerUpdateHandler(changeColorsMonster4);
monsterBottomRight.registerUpdateHandler(cakaj);
break;
}
default : break;
}
mReverseStack.push(monsterString);
}
}
但是,我真的建议不要使用这种代码。你应该尝试将你的怪物本身推到一个堆栈而不是数字上,并使用参数使 changeColors-Stuff 更通用。或者,至少将 if 或 case 语句中的一些代码放入单独的方法中。上面代码中的这种冗余不是好的编码风格,你迟早会遇到问题。
如果您希望while()
周期减少堆栈,请使用pop()
而不是peek()