这个用于排名的 MySQL 触发器有什么问题



我正在尝试编写一个触发器,该触发器将表中的所有条目从 1 到 10 进行排名(最大值具有等级 10,最小值具有等级 1,所有其他值都分配了介于两者之间的整数值)。这是触发代码:

DELIMITER $$
CREATE TRIGGER risks_before_insert BEFORE INSERT ON risks
FOR EACH ROW
BEGIN
DECLARE n_project_id integer; #project_id associated with risk
DECLARE max_cost double; #previous maximum expected_cost in project
DECLARE min_cost double; #previous minimum expected_cost in project
DECLARE max_impact double; #previous maximum impact_effect in project
DECLARE min_impact double; #previous minimum impact_effect in project
DECLARE slope double; #slope for prioritizing function
SELECT t.project_id INTO n_project_id FROM tasks t WHERE t.task_id = NEW.task_id; #GET PROJECT_ID ASSOCIATED WITH THE RISK
SET NEW.expected_cost = NEW.probability * NEW.cost_impact, NEW.overall_impact = NEW.probability * NEW.impact_effect; #CALCULATE EXPECTED_COST AND OVERALL_IMPACT FIELDS
SELECT MAX(expected_cost), MIN(expected_cost), MAX(overall_impact), MIN(overall_impact) INTO max_cost, min_cost, max_impact, min_impact FROM view_risks WHERE r.project_id = n_project_id; #GET EXTREME VALUES FROM TABLE, STORE IN MEMORY
/*
Update Priority Monetary Rankings
*/
IF (max_cost IS NULL OR min_cost IS NULL) THEN #check for empty table
    SET NEW.priority_monetary = 10;
ELSEIF ((NEW.expected_cost <= max_cost) AND (NEW.expected_cost >= min_cost)) THEN 
#NEW VALUE DOES NOT CHANGE TABLE EXTREMES
    IF (max_cost - min_cost = 0) THEN
        SET NEW.priority_monetary = 10;
    ELSE
        SET slope = 9 / (max_cost - min_cost);
SET NEW.priority_monetary = slope * (NEW.expected_cost - min_cost) + 1;
    END IF;
ELSEIF (NEW.expected_cost > max_cost) THEN
    SET NEW.priority_monetary = 10;
    SET slope = 9 / (NEW.expected_cost - min_cost);
    UPDATE risks SET priority_monetary = slope * (expected_cost - min_cost) + 1 WHERE project_id = n_project_id;
ELSE #NEW VALUE CORRESPONDS TO A MINIMUM
    SET NEW.priority_monetary = 1;
    SET slope = 9 / (max_cost - NEW.expected_cost);
    UPDATE risks SET priority_monetary = slope * (expected_cost - min_cost) + 1 WHERE project_id = n_project_id;
END IF;
/*
Update Priority Effect Rankings
*/
IF (max_impact IS NULL OR min_impact IS NULL) THEN #check for empty table
    SET NEW.priority_effect = 10;
ELSEIF ((NEW.overall_impact <= max_impact) AND (NEW.overall_impact >= min_impact)) THEN 
#NEW VALUE DOES NOT CHANGE TABLE EXTREMES
    IF (max_cost - min_cost = 0) THEN
        SET NEW.priority_effect = 10;
    ELSE
        SET slope = 9 / (max_impact - min_impact);
SET NEW.priority_effect = slope * (NEW.overall_impact - min_impact) + 1;
    END IF;
ELSEIF (NEW.overall_impact > max_impact) THEN
    SET NEW.priority_effect = 10;
    SET slope = 9 / (NEW.overall_impact - min_impact);
    UPDATE risks SET priority_effect = slope * (overall_impact - min_impact) + 1 WHERE project_id = n_project_id;
ELSE #NEW VALUE CORRESPONDS TO A MINIMUM
    SET NEW.priority_effect = 1;
    SET slope = 9 / (max_impact - NEW.overall_impact);
    UPDATE risks SET priority_effect = slope * (overall_impact - min_impact) + 1 WHERE project_id = n_project_id;
END IF;
END
DELIMITER ;

但是,我收到以下错误:

#1064 - You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '' at line 5 

谁能解释出什么问题?供您参考,我的排名算法由以下函数描述,常量为 maxval 和 minval:

秩 (x) = 1 + 斜率(x - 最小值),其中斜率 = 9/(最大值 - 最小值)。

谢谢!

附加信息:

字段类型:expected_cost => 十进制(11,2)priority_monetary => 小音(2)

示例值:expected_cost => 1000.00priority_monetary => 2

你有 ELSE IF 你应该在你应该使用 ELSEIF 的地方。

同样正如@Mihai所写:你的缺点不显示为缺点,并且在更新后你有关键字TABLE(应该只有UPDATE tableName)。

PS 我建议您使用一些用于MySql的工具,例如MySql Workbench,它具有Windows,大多数Linux系统和OSX的发行版。它会让你工作得更好,并检查你的语法。

更改后的代码:

DELIMITER $$
CREATE TRIGGER risks_before_insert
BEFORE INSERT ON risks
FOR EACH ROW
BEGIN
DECLARE max_cost double; #previous maximum expected_cost in project
DECLARE min_cost double; #previous minimum expected_cost in project
DECLARE slope double; #slope for prioritizing functioN
SELECT MAX(expected_cost), MIN(expected_cost) INTO max_cost, min_cost FROM view_risks; #GET EXTREME VALUES FROM TABLE, STORE IN MEMORY
/*
Update Priority Monetary Rankings
*/
IF (max_cost IS NULL OR min_cost IS NULL) THEN #check for empty table
    SET NEW.priority_monetary = 10;
ELSEIF ((NEW.expected_cost <= max_cost) AND (NEW.expected_cost >= min_cost)) THEN #NEW VALUE DOES NOT CHANGE TABLE EXTREMES
    IF (max_cost - min_cost = 0) THEN
        SET NEW.priority_monetary = 10;
    ELSE
        SET slope = 9 / (max_cost - min_cost);
        SET NEW.priority_monetary = slope * (NEW.expected_cost - min_cost) + 1;
    END IF;
ELSEIF (NEW.expected_cost > max_cost) THEN
    SET NEW.priority_monetary = 10;
    SET slope = 9 / (NEW.expected_cost - min_cost);
    UPDATE risks SET priority_monetary = slope * (expected_cost - min_cost) + 1;
ELSE #NEW VALUE CORRESPONDS TO A MINIMUM
    SET NEW.priority_monetary = 1;
    SET slope = 9 / (max_cost - NEW.expected_cost);
    UPDATE risks SET priority_monetary = slope * (expected_cost - NEW.min_cost) + 1;
END IF;
END $$
DELIMITER ;

在我的MySql客户端中,您的缺点没有显示为缺点,还进行了一些小的修改(更新表名称没有关键字TABLE)

DELIMITER $$
CREATE TRIGGER risks_before_insert
BEFORE INSERT ON risks
FOR EACH ROW
BEGIN
DECLARE max_cost double; #previous maximum expected_cost in project
DECLARE min_cost double; #previous minimum expected_cost in project
DECLARE slope double; #slope for prioritizing functioN
SELECT MAX(expected_cost), MIN(expected_cost) INTO max_cost, min_cost FROM view_risks; #GET EXTREME VALUES FROM TABLE, STORE IN MEMORY
/*
Update Priority Monetary Rankings
*/
IF (max_cost IS NULL OR min_cost IS NULL) THEN #check for empty table
    SET NEW.priority_monetary = 10;
ELSE IF ((NEW.expected_cost <= max_cost) AND (NEW.expected_cost >= min_cost)) THEN #NEW VALUE DOES NOT CHANGE TABLE EXTREMES
    IF (max_costs - min_cost = 0) THEN
        SET NEW.priority_monetary = 10;
    ELSE
        SET slope = 9 / (max_cost - min_cost);
        SET NEW.priority_monetary = slope * (NEW.expected_cost - min_cost) + 1;
    END IF;
ELSE IF (NEW.expected_cost > max_cost) THEN
    SET NEW.priority_monetary = 10;
    SET slope = 9 / (NEW.expected_cost - min_cost);
    UPDATE risks SET priority_monetary = slope * (expected_cost - min_cost) + 1;
ELSE #NEW VALUE CORRESPONDS TO A MINIMUM
    SET NEW.priority_monetary = 1;
    SET slope = 9 / (max_cost - NEW.expected_cost);
    UPDATE risks SET priority_monetary = slope * (expected_cost - NEW.min_cost) + 1;
END IF;
END $$
DELIMITER ;

最新更新