这些是我的。java类。我是否正确地实现了适配器模式?
界面播放
public interface Play {
public void Tune(String Type,String Guitar);
}
<<p> advanceTuning接口/strong> public interface AdvanceTuning {
public void getSharp(String Guitar);
public void getLowKey(String Guitar);
}
lowkeytuning.java
public class LowKeyTuning implements AdvanceTuning{
@Override
public void getSharp(String Guitar) {
// TODO Auto-generated method stub
}
@Override
public void getLowKey(String Guitar) {
// TODO Auto-generated method stub
System.out.println(Guitar+": Guitar Tuned to LowKey");
}
}
Guitar.java
public class Guitar implements Play{
Adapter adapter;
@Override
public void Tune(String Type, String Guitar) {
// TODO Auto-generated method stub
if(Type.equalsIgnoreCase("Standard")){
System.out.println(Guitar+": Guitar Tuned to Standard");
}
else if(Type.equalsIgnoreCase("Sharp") || Type.equalsIgnoreCase("LowKey")){
adapter=new Adapter(Type);
adapter.Tune(Type, Guitar);
}
else{
System.out.println("No Such Tuning exists as "+Type);
}
}
}
Adapter.java
public class Adapter implements Play{
AdvanceTuning aTune;
public Adapter(String Type){
if(Type.equalsIgnoreCase("Sharp")){
aTune= new SharpTuning();
}
else if(Type.equalsIgnoreCase("LowKey")){
aTune= new LowKeyTuning();
}
}
@Override
public void Tune(String Type,String Guitar) {
// TODO Auto-generated method stub
if(Type.equalsIgnoreCase("Sharp")){
aTune.getSharp(Guitar);
}
else if(Type.equalsIgnoreCase("LowKey")){
aTune.getLowKey(Guitar);
}
}
}
SharpTuning.java与Lowkey.java相同
和我有一个client.java类,它创建一个吉他。java的对象,并调用它的方法Tune();
我有一些建议:
移动代码:
if(Type.equalsIgnoreCase("Sharp")){
aTune= new SharpTuning();
}
else if(Type.equalsIgnoreCase("LowKey")){
aTune= new LowKeyTuning();
}
变成某种工厂方法
iestatic AdvanceTuning create(String string){
if(Type.equalsIgnoreCase("Sharp")){
return new SharpTuning();
}
else if(Type.equalsIgnoreCase("LowKey")){
return new LowKeyTuning();
}
}
您的适配器,使其不接受字符串,而是接受AdvancedTune
。然后,如果有必要,您将能够重用现有的曲调。那么你的构造函数就会像这样
public Adapter(AdvanceTuning aTune){
this.aTune=aTune;
}
那么你可以通过adapter = new Adapter(create(type))
您还可以考虑删除字符串常量,如Sharp
或LowKey
,并将其替换为enum。
但是总的来说,看看你的代码,它给我带来了一个问题,在你的情况下使用适配器的目的是什么?我看不出你能从中得到什么