为什么我不能减少我的数组列表/链接列表中的所有元素

Question

原始问题：

最初，我想为MyLinkedList中的所有元素减少（1）。但是，由于我不能在MyLinkedList中使用foreach循环，我首先将MyLinkedList中的所有元素转移到ArrayList，然后对所有元素减少foreach循环（1）。但问题是，我想每秒做一次递减运算。

input : 5-6-7
output : 1 second : 4-5-6 
         2 second : 3-4-5 ...

我的问题：

我的代码的问题是：对于ArrayList的第i个元素，它每秒减少（1）。

input : 5-6-7
output : 1 second 4-6-7
         2 second 4-5-6
         ...

这是我迄今为止的代码。

public void decreaseTime(MyLinkedList l1,MyLinkedList l2) {
        ArrayList<Integer> arr = new ArrayList<Integer>();
        Node tmp = l1.first;

        /*originally i want to decrease 1 for all elements of mylinkedlist.       
          since i cannot 
          use foreach in mylinkedlist i first transferred 
          elements of mylinkedlist to an Arraylist arr. 
          then decreased 1 for each element.*/
        //lltoarr does copy all mylinkedlist elements to ArrayList arr.
        lltoarr(l1, arr);
        while (tmp != null) {
            // simple sleep method which pauses the program for 1 second.
            sleep();
            int j = 0;
            //decrease operation for each element of arr
            for (int t : arr) {
                //this is a trick for my program to work. you may ignore the next line. 
                int c = tmp.data.length() - 1;

                t--;
                arr.set(j, t);
                // timeNew gets the new time which is the edited t element
                int timeNew = arr.get(j);

                if (somethin) {
                    //copy timeNew to String. i must store the time as string in mylinkedlist.
                    String newData = tmp.data.substring(0, c - 2) + timeNew
                            + "h";

                    tmp.data = newData;
                    System.out.println(tmp.data);
                    sleep();
                    tmp = tmp.next;
                }
                else {
                    String newData = tmp.data.substring(0, c - 1) + timeNew
                            + "h";
                    tmp.data = newData;
                    System.out.println(tmp.data);
                    sleep();
                    tmp = tmp.next;
                }       
                j++;
            } 
            System.out.println(arr);
            }
        }

MyLinkedList类：

import java.lang.reflect.Array;
import java.util.ArrayList;
import java.util.LinkedList;
public class MyLinkedList {
    Node first, last;

    public void insertFirst(String s) {
        Node n = new Node(s);
        if (first == null) {
            last = n;
        }
        n.next = first;
        first = n;
    }
    public void insertLast(String s) {
        Node n = new Node(s);
        if (first == null) {
            first = n;
        } else {
            last.next = n;
        }
        last = n;
    }

    public void deleteFirst() {
        if (first.next == null) {
            first = null;
            last = null;
        }
        else if (first == null)
            return;
        else
            first = first.next;
    }

    public void lltoarr(MyLinkedList ll, ArrayList<Integer> arr) {
        Node tmp = ll.first;
        while (tmp != null) {
            String numberOnly = tmp.data.replaceAll("[^0-9]", "");
            int time = Integer.parseInt(numberOnly);
            arr.add(time);
            tmp = tmp.next;
        }
    }

    //decreaseTime method here

    public void sleep() {
        try {
            Thread.sleep(1000); 
        } catch (InterruptedException ex) {
            Thread.currentThread().interrupt();
        }
    }
    public void print() {
        Node tmp = first;
        int i = 0;
        while (tmp != null) {
            System.out.print(tmp.data + " - ");
            tmp = tmp.next;
        }
    }
    public int nOfNodes() {
        int n = 0;
        Node tmp = first;
        while (tmp != null) {
            tmp = tmp.next;
            n++;
        }
        return n;
    }

    public Node search(String s) {
        Node tmp = first;
        while (tmp != null) {
            if (tmp.data == s) {
                return tmp;
            } else {
                tmp = tmp.next;
            }
        }
        return null;
    }
    public void llCopy(MyLinkedList ll, MyLinkedList llcopy,int i) {
            llcopy.insertLast(ll.nthNode(i));

    }
    public void insertAfter(String s, Node n) {
        Node nn = new Node(s);
        nn.next = n.next;
        n.next = nn;
    }
} 

Answer 1

如何对列表进行索引是行不通的。

如果你想遍历列表并调整每个值，我建议用一个具有递减函数的持有者来包装Integer值

例如

public IntegerHolder {

    private int value;
....
    public void decrement(){
        this.value--;
    }
}

然后你可以做这个

for(IntegerHolder value : list){
    value.decrement();
}

否则，您可以使用ListIterator，删除旧值并插入递减的值

for(ListIterator<Integer> iter = list.listIterator();iter.hasNext();){
    int value = iter.next(); // get current value
    iter.remove(); // remove it from list
    iter.add(value-1); // insert decremented value where old value was
}

就我个人而言，我发现集合的foreach循环价值有限。通常我出于某种原因想访问迭代器，但它不允许我访问。