OKHTTP3 文件描述符过多的问题

Question

>我有一个下载图像的图像"管理器"。以前我使用毕加索图书馆如下

class DownloadImage implements Runnable {
    String url;
    Context context;
    public DownloadImage(String url, Context context) {
        this.url = url;
        this.context = context;
    }
    @Override
    public void run() {
        try {
            String hash = Utilities.getSha1Hex(url);
            FileOutputStream fos = context.openFileOutput(hash, Context.MODE_PRIVATE);
            Bitmap bitmap = Picasso.with(context)
                    .load(url)
                    .resize(1024, 0) // Height 0 to ensure the image is scaled with respect to width - http://stackoverflow.com/a/26782046/1360853
                    .onlyScaleDown()
                    .memoryPolicy(MemoryPolicy.NO_CACHE)
                    .get();
            // Writing the bitmap to the output stream
            bitmap.compress(Bitmap.CompressFormat.JPEG, 80, fos);
            fos.close();
            bitmap.recycle();
        } catch (IOException e) {
            Timber.e(e, "For url %s", url);
        } catch (OutOfMemoryError e) {
            Timber.e(e, "out of memory for url %s", url);
        }
    }
}

但这会创建一个位图对象，该对象不仅消耗大量内存，而且速度相当慢且不必要。

我已经修改了这个 Runnable 以改用okhttp3：

class DownloadImage implements Runnable {
    String url;
    Context context;
    public DownloadImage(String url, Context context) {
        this.url = url;
        this.context = context;
    }
    @Override
    public void run() {
        try {
            String hash = Utilities.getSha1Hex(url);
            final FileOutputStream fos = context.openFileOutput(hash, Context.MODE_PRIVATE);
            Request request = new Request.Builder().url(url).build();
            okHttpClient.newCall(request).enqueue(new Callback() {
                @Override
                public void onFailure(Call call, IOException e) {
                    try {
                        fos.close();
                    } catch (IOException e1) {
                        e1.printStackTrace();
                    }
                }
                @Override
                public void onResponse(Call call, Response response) throws IOException {
                    Sink sink = null;
                    BufferedSource source = null;
                    try {
                        source = response.body().source();
                        sink = Okio.sink(fos);
                        source.readAll(sink);
                    } catch (Exception e) {
                        Timber.e(e, "Downloading an image went wrong");
                    } finally {
                        if (source != null) {
                            source.close();
                        }
                        if (sink != null) {
                            sink.close();
                        }
                        fos.close();
                        okHttpClient.connectionPool().evictAll(); // For testing
                    }
                }
            });
        } catch (IOException e) {
            Timber.e(e, "For url %s", url);
        }
    }
}

虽然这种方法比以前的方法快得多，但对于大量图像，我得到A/libc: FORTIFY_SOURCE: FD_SET: file descriptor >= FD_SETSIZE. Calling abort().然后是微转储，这意味着我打开了太多文件描述符。

为了测试起见，我添加了okHttpClient.connectionPool().evictAll(); // For testing行，但这不起作用。我也尝试在构建okHttpClient时设置builder.connectionPool(new ConnectionPool(4, 500, TimeUnit.MILLISECONDS));，但这也没有做任何事情。我也知道 https://github.com/square/okhttp/issues/2636

我似乎关闭了所有流/接收器/源，那么这里发生了什么？

运行对象使用其execute函数添加到ThreadPoolExecutor，该函数的创建方式如下：

// Sets the amount of time an idle thread waits before terminating
private static final int KEEP_ALIVE_TIME = 500;
// Sets the Time Unit to milliseconds
private static final TimeUnit KEEP_ALIVE_TIME_UNIT = TimeUnit.MILLISECONDS;
private static int NUMBER_OF_CORES = Runtime.getRuntime().availableProcessors();
// A queue of Runnables
private final BlockingQueue<Runnable> mDecodeWorkQueue;
private OkHttpClient okHttpClient;
ThreadPoolExecutor mDecodeThreadPool;
public ImageManager() {
    // Instantiates the queue of Runnables as a LinkedBlockingQueue
    mDecodeWorkQueue = new LinkedBlockingQueue<Runnable>();
    // Creates a thread pool manager
    mDecodeThreadPool = new ThreadPoolExecutor(
            NUMBER_OF_CORES,       // Initial pool size
            NUMBER_OF_CORES,       // Max pool size
            KEEP_ALIVE_TIME,
            KEEP_ALIVE_TIME_UNIT,
            mDecodeWorkQueue);
}

Answer 1

通过在 OnResponse 正文中创建和使用FileOutputStream解决了这个问题，以便在请求完成时它不会打开。