CRUD方法，用于belongs_to许多模型的模型Rails

Question

我是Rails的新手，我可能在这里错过了一些非常基本的东西：

用户可以为公司的分支机构和部门创建联系人

分支.rb

class Branch < ApplicationRecord
    belongs_to :company
    has_many :contacts
end

分部.rb

class Division < ApplicationRecord
    belongs_to :company
    has_many :contacts
end

联系方式.rb

class Contact < ApplicationRecord
    belongs_to :branch
    belongs_to :division
end

现在，用户可以从没有division_id的分支页面创建联系人，并且可以从"部门"页面创建联系人。

我像这样定义我的routes.rb：

路线.rb

resources :companies, :shallow => true do
    get 'company_page'
    resources :branches, :shallow => true do
        get 'branch_page'
        resources :contacts
    end 
    resources :divisions, :shallow => true do
        get 'division_page'
        resources :contacts
    end 
end 

因此，如果我从分支机构或部门创建联系人，它将转到联系人#创建方法。

在我的contacts_controller.rb中，我有：

def create
    @newContact = Contact.new(contact_params)
    id = @division = @branch = nil
    isBranch = false
    if params[:branch_id] != nil
        isBranch = true
        id = params[:branch_id]
    else
        isBranch = false
        id = params[:division_id]
    end 
    if isBranch
      branch = Branch.find(id) 
      @newContact.branch = branch
      @branch = branch
    else
      division = Division.find(id) 
      @newContact.division = division
      @division = division
    end  
    respond_to do |format|
        if @newContact.save
          format.js
          format.html { render :nothing => true, :notice => 'Contact created successfully!' }
          format.json { render json: @newContact, status: :created, location: @newContact }
        else
          format.html { render action: "new" }
          format.json { render json: @newContact, status: :unprocessable_entity }
        end
    end     
end

但是我在@newContact.save期间面临ActiveRecord Error.

我

确信我在这里做了一些根本上非常错误的事情，Rails 以我不知道的另一种优雅的方式处理这些事情。

Answer 1

如@Anthony所述，您需要将belongs_to关联设置为可选：

# app/models/contact.rb
class Contact < ApplicationRecord
  belongs_to :branch, optional: true
  belongs_to :division, optional: true
end

但另一个问题是，params[:division_id]和params[:branch_id]总是零。这两个密钥都存在于[:contact]密钥中。因此，您遇到的错误应该是ActiveRecord::RecordNotFound: Couldn't find Division with 'id'=

所有这些条件逻辑都是不必要的。你可以用给出的任何参数进行新的接触。此外，您应该使用 Ruby 约定进行变量命名，这是snake_case而不是 camelCase。

最后，我假设您希望将 HTML 请求重定向到分支或部门显示页面，具体取决于关联的页面。所以我添加了逻辑来做到这一点。

下面是控制器#create操作的快速重构：

  def create
    @new_contact = Contact.new(contact_params)
    if @new_contact.save
      branch = @new_contact.branch
      division = @new_contact.division
      redirect_path = branch ? branch_path(branch) : division_path(division)
      respond_to do |format|
        format.js
        format.html { redirect_to redirect_path, :notice => 'Contact created successfully!' }
        format.json { render json: @new_contact, status: :created, location: @new_contact }
      end
    else
      respond_to do |format|
        format.html { render action: "new" }
        format.json { render json: @new_contact, status: :unprocessable_entity }
      end
    end
  end

这证明它有效：

# spec/controllers/contacts_controller_spec.rb
require 'rails_helper'
RSpec.describe ContactsController, type: :controller do
  let(:company) { Company.create!(name: 'Company Name') }
  let(:division) { Division.create!(name: 'Division Name', company: company) }
  let(:branch) { Branch.create!(name: 'Branch Name', company: company) }
  describe '#create' do
    context 'when created with a division id' do
      let(:attributes) { {'division_id' => division.id, 'name' => 'Contact Name'} }
      it 'creates a contact record and associates it with the division' do
        expect(Contact.count).to eq(0)
        post :create, params: {contact: attributes}
        expect(Contact.count).to eq(1)
        contact = Contact.first
        expect(contact.division).to eq(division)
      end
    end
    context 'when created with a branch id' do
      let(:attributes) { {'branch_id' => branch.id, 'name' => 'Contact Name'} }
      it 'creates a contact record and associates it with the branch' do
        expect(Contact.count).to eq(0)
        post :create, params: {contact: attributes}
        expect(Contact.count).to eq(1)
        contact = Contact.first
        expect(contact.branch).to eq(branch)
      end
    end
  end
end