方法不会在对象ArrayList中增加int变量

Question

我一直有一个'Loanbook'方法的问题，它的功能是将存储在对象ArrayList中的'numOnLoan'变量增加1，但当我运行该方法时，它似乎不会改变值。

//Allows loaning of books
public static void Loanbook(Scanner sc, ArrayList<Book> books){
System.out.println("Please enter a book title");
    if(sc.hasNext()){
        String criteria = sc.nextLine();
        for (int i = 0; i < books.size(); i++){
            if(criteria.equals(books.get(i).getBookTitle())){
            System.out.println("The book " + books.get(i).getBookTitle() + " there are " + books.get(i).getNumInStock() + " in stock");
                    books.get(i).setNumOnLoan(books.get(i).GetNumOnLoan()+1);
                    System.out.println("number on loan: " + books.get(i).GetNumOnLoan()); break;    
                        }
                    } System.out.println("Book Loaned");
                        LibraryTester.MenuReturn(sc, books);
            }   
                LibraryTester.MenuReturn(sc, books);
        }

我怀疑这是代码逻辑的问题，因为无论我如何编辑它，代码似乎都没有达到我想要的效果。

编辑：book.java

public class Book {
private int id;
private String bookTitle;
private String authorName;
private int bookReleaseYear;
private int numOnLoan;
private int numInStock;
//constructor
public Book(int id, String bookTitle, String authorName, int bookReleaseYear, int numOnLoan, int numInStock) {
    this.id = id;
    this.bookTitle = bookTitle;
    this.authorName = authorName;
    this.bookReleaseYear = bookReleaseYear;
    this.numOnLoan = numOnLoan;
    this.numInStock = numInStock;
}
//Getters/Setters
public int getId() {
    return id;
}
public void setId(int id) {
    this.id = id;
}
public String getBookTitle() {
    return bookTitle;
}
public void setBookTitle(String bookTitle) {
    this.bookTitle= bookTitle;
}
public String getAuthorName() {
    return authorName;
}
public void setAuthorName(String authorName) {
    this.authorName = authorName;
}
public int GetNumOnLoan() {
    return numOnLoan;
}
public void setNumOnLoan(int numOnLoan) {
    this.numOnLoan = numOnLoan;
}
public int getNumInStock() {
    return numInStock;
}
public void setNumInStock(int numInStock) {
    this.numInStock = numInStock;
}

public int getBookReleaseYear() {
    return bookReleaseYear;
}
public void setBookReleaseYear(int bookReleaseYear) {
    this.bookReleaseYear = bookReleaseYear;
}

Library.java

import java.util.ArrayList;
import java.util.Scanner;
public class Library {
public ArrayList<Book> books = new ArrayList<Book>();
public Library(){
      super();
    }
//Getters/Setters
public Library(ArrayList<Book> books) {
    this.books = books;
}
public ArrayList<Book> getBooks() {
    return books;
}
public void setBooks(ArrayList<Book> books) {
    this.books = books;
}
//Methods
//Allows loaning of books
public static void Loanbook(Scanner sc, ArrayList<Book> books){
System.out.println("Please enter a book title");
    if(sc.hasNext()){
        String criteria = sc.nextLine();
        for (int i = 0; i < books.size(); i++){
            if(criteria.equals(books.get(i).getBookTitle())){
            System.out.println("The book " + books.get(i).getBookTitle() + "    there are " + books.get(i).getNumInStock() + " in stock");
                    books.get(i).setNumOnLoan(+1);
                    System.out.println("number on loan: " +    books.get(i).GetNumOnLoan()); break; 
                        }
                    } System.out.println("Book Loaned");
                        LibraryTester.MenuReturn(sc, books);
            }   
                LibraryTester.MenuReturn(sc, books);
        }

}
public static void Returnbook(Scanner sc, ArrayList<Book> books){
System.out.println("Please enter a book title");
    if(sc.hasNext()){
        String criteria = sc.nextLine();
    for (int i = 0; i < books.size(); i++){
        if(criteria.equals(books.get(i).getBookTitle())){
        System.out.println("The book " + books.get(i).getBookTitle() +
        " is in stock," + " there are " + books.get(i).getNumInStock() + " in stock and " + books.get(i).GetNumOnLoan() + " out on loan");
        books.get(i).setNumOnLoan(-1);; break;
                        } 

                    } System.out.println("Book returned");
                        LibraryTester.MenuReturn(sc, books);
            }
        }

LibraryTester.java

import java.util.ArrayList;
import java.util.Collections;
import java.util.Comparator;
import java.util.Scanner;
public class LibraryTester {
public static void main(String[] args) {
    Scanner sc = new Scanner(System.in);
    Library lib = new Library();
    ArrayList<Book> books = lib.getBooks();
    books = Library.CreateBooksArrayList();
    MenuInput(sc, books);
    sc.close();
    lib.setBooks(books);
}

//prints menu
public static void PrintMenu(){
    System.out.println("Public Library Menu System");
    System.out.println("---------------------------");
    System.out.println("1: Add Book");
    System.out.println("2: Search for book");
    System.out.println("3: Loan Book");
    System.out.println("4: Return Book");
    System.out.println("5: Amend Book Details");
    System.out.println("6: Display all Books");
    System.out.println("7: Delete a Book");
    System.out.println("8: Other Options");
    System.out.println("9: Exit system");
    System.out.println("----------------------------");
}

// Allows menu input
public static void MenuInput(Scanner sc, ArrayList<Book> books){
int input = 0;
PrintMenu();
if(sc.hasNextInt()){
    input = sc.nextInt();
    switch(input){
    case 1:Library.AddBook(sc, books);
    case 2:Library.SearchBooks(sc, books);;
    case 3:Library.Loanbook(sc,books);
    case 4:Library.Returnbook(sc, books);
    case 5:Library.AmendDetails(sc,books);
    case 6:Library.DisplayAllBooks(sc,books);
    case 7:Library.Removebook(sc, books);;
    case 8:OtherMenu(sc,books);
    case 9:System.exit(0);
    }
} else {
    System.out.println("Please enter a number");
}

}

//Returns user to main menu
public static void MenuReturn(Scanner sc, ArrayList<Book> books){
System.out.println("Press any key to return to the main menu");
if(sc.hasNextLine()){
    sc.nextLine();
    MenuInput(sc, books);
    }
}


}

编辑：我似乎得到了输出：

Please enter a book title
Input:   book1
Please enter a book title
The book book1 is in stock, there are 5 in stock and 1 out on loan
Book returned
Press any key to return to the main menu

Final Edit：修复了这个问题，由于if语句的问题，代码没有运行，当我删除它时，所有文本同时出现了问题，这是用额外的"sc.nextLine"修复的。ReturnBook在没有调用的情况下运行的问题是由于缺少"break；"在菜单系统中。

感谢大家的帮助，尤其是Shryans Sheth

Answer 1

我刚刚深入研究了您的代码

你似乎有一个讨厌的bug（如果是的话）

我将在您的问题中解决特定的行："它的功能是将存储在对象ArrayList中的'numOnLoan'变量增加1，但当我运行该方法时，它似乎不会更改值。"

原始方法：

public void setNumOnLoan(int numOnLoan)  
{
    this.numOnLoan= numOnLoan;
}

Loanbook中的方法调用：

books.get(i).setNumOnLoan(1);

在LoanBook方法中，只需传递"+1"作为参数，每次只分配1。这是你需要做的。

public void setNumOnLoan(int numOnLoan)  
{
    //When numOnLoan is 1, as you have passed everytime
    //the current value gets incremented by one. I think that is what you wanted.
    this.numOnLoan += numOnLoan; //You add it to the existing variable
}

你真的应该用别的名字来命名这个函数。我很确定还有更多的bug，但这能实现你想要的吗？

输出：
（第一次呼叫Loanbook）
请输入书名
输入：bbbbb
这本书bbbbb有5本存货
贷款数量：2
借出书籍

（第二次呼叫Loanbook）
请输入书名
输入：bbbbb
这本书bbbbb有5本存货
贷款数量：3
借出书籍