我必须使用多个模型处理非常长的形式。
def registerCandidate
action_redirect = ""
id = ""
ActiveRecord::Base.transaction do
begin
@entity = Entity.new( name: params[:entity][:name], description: params[:entity][:description], logo: params[:entity][:logo])
@access = Access.new( username: params[:access][:username], password: params[:access][:password], remember_me: params[:access][:rememberme], password_confirmation: params[:access][:password_confirmation])
@access.entity = @entity
@access.save!
@biodata = Biodatum.new(
date_of_birth: params[:biodatum][:birthday],
height: params[:biodatum][:height],
family_members: params[:biodatum][:family_members],
gender: params[:biodatum][:gender],
complexion: params[:biodatum][:complexion],
marital_status: params[:biodatum][:marital_status],
blood_type: params[:biodatum][:blood_type],
religion: params[:biodatum][:religion],
education: params[:biodatum][:education],
career_experience: params[:biodatum][:career_experience],
notable_accomplishments: params[:biodatum][:notable_accomplishments],
emergency_contact: params[:biodatum][:emergency_contact],
languages_spoken: params[:biodatum][:languages_spoken]
)
@biodata.entity = @entity
@biodata.save!
@employee = Employee.new()
@employee.entity = @entity
@employee.save!
action_redirect = "success_candidate_registration"
id = @access.id
#action_redirect = "success_candidate_registration?id=" + @access.id
#Error Processing
rescue StandardError => e
flash[:collective_errors] = "An error of type #{e.class} happened, message is #{e.message}"
action_redirect = "candidate_registration"
end
end
redirect_to action: action_redirect, access_id: id
end
如果我提出了@access.save!
以外的任何错误,则它可以完成整个交易而不会回滚。您如何修改以获取与所有模型回滚有关的任何错误?
由于您正在拯救标准eRROR-大多数错误可能是吞咽错误,这可能会导致回滚。
这通常被称为口袋妖怪例外处理(必须抓住em'),是一个反图案。
而是收听更具体的错误,例如ActiveRecord::RecordInvalid
-并在错误时提出raise ActiveRecord::Rollback
以引起回滚。
如果您尚未阅读主动记录交易文档,那么那里有一些非常好的信息会导致回滚。
另外,如果您想成为一个好红宝石公民,并遵循最小令人惊讶的原则使用snakecase( register_candidate
),而不是骆驼(registerCandidate
),则在命名方法时。
添加
而不是将每个值从参数复制到模型,而是应该使用强参数并传递模型ah。
这减少了控制器操作之间的代码重复,并使您的控制器保持良好和瘦。
class Biodatum < ActiveRecord::Base
alias_attribute :date_of_birth, :birthday # allows you to take the :birthday param
end
# in your controller:
def register_candidate
# ...
@biodata = Biodatum.new(biodatum_params)
# ...
end
private
def biodatum_params
params.require(:biodatum).allow(
:birthday, :height, :family_members :family_members
) # @todo whitelist the rest of the parameters.
end