我试图返回一个散列数组，但只有最后一个散列被添加到该数组中

Question

以下是我如何获得所有手

def get_all_hands
doc = Nokogiri::HTML(open('http://www.cardplayer.com/rules-of-poker/hand-rankings'))
hand_hash = {}
hands_array = []
doc.css('div#rules-of-poker-accordion').each do |hands|
hands.css('strong').each do |hand|
hand_hash[:name] = hand.text
end
hands.css('div.rules-cards').each do |hand|
hand_value = []
hand.css('img').each do |card|
hand_value << card.attr('src')
hand_hash[:value] = hand_value
end
end
hands_array << hand_hash
end
hands_array
end
HandScraper.new.get_all_hands

返回：

[{:name=>"10. High Card",
:value=>
["/packages/cards/Large/Diamond/3-909f8b1571f834c774576c93eae26594.png",
"/packages/cards/Large/Club/J-58b4c0f26e3e0cf8c0772ab3e9e34784.png",
"/packages/cards/Large/Spade/8-60d335b08119f600c3ca02aa58fa902d.png",
"/packages/cards/Large/Heart/4-712ce04b7f2c7e588c48a1e2b46a4244.png",
"/packages/cards/Large/Spade/2-e2d1cee5fc0db0b70990036153d57906.png"]}]

这是第十只也是最后一只手，当我希望它全部返回10只时。

Answer 1

这段特定的代码是它不起作用的原因。您正在对每个strong进行迭代，将值分配给hand_hash的相同密钥(:name)。下一次迭代也是如此。基本上，直到最后一次迭代，您都在重写相同的散列，而不将其保存在任何位置。

hands.css('strong').each_with_index do |hand, index|
hand_hash[index] = hand.text
end

我在你自己的代码中做了一些更改来修复这个问题：

doc = Nokogiri::HTML(open('http://www.cardplayer.com/rules-of-poker/hand-rankings'))
hands_array = []
doc.css('div#rules-of-poker-accordion').each do |hands|
hands.css('strong').zip(hands.css('div.rules-cards')).each do |hand, value|
hand_hash = {}
hand_hash[:name] = hand.text
hand_value = []
value.css('img').each do |card|
hand_value << card.attr('src')
hand_hash[:value] = hand_value
end
hands_array << hand_hash #here, now you are saving after each hand
end
end
hands_array

hands.css('strong').zip(hands.css('div.rules-cards'))将对每个名称和规则进行配对，然后将其添加到hands_array中。

结果：

[｛：name=>"1.皇家同花顺"，：value=>
["/packages/cards/Large/DDiamond/A-49a04aae5e96d2f948dc2062c4fcd5.png"，"/packages/cards/Large/D菱形/K-0bfc14d8f58cc13891b108e4178f92f9.png"，"/packages/cards/Large/D菱形/Q-b981aa1f57642480de1dceaf1c2e810f.png"，"/packages/cards/Large/D菱形/J-d915fc38dbca1ca74cdd75dd913de1f3.png"，"/packages/cards/Large/DDiamond/T-ef2fe11bbd701e4c5b6681e506271700.png"]}，｛：name=>"2.直齐平"｝，｛：name＝>"3。四种"，：value=>["/packages/cards/Large/Heart/J-2bf19067cda29391286416d0d00646d6.png"，"/packages/cards/Large/D菱形/J-d915fc38dbca1ca74cdd75dd913de1f3.png"，"/packages/cards/Large/Spade/J-fff29c49da8ca1f7a272c5ac83f51d06.png"，"/packages/cards/Large/Club/J-58b4c0f26e3e0cf8c0772ab3e9e34784.png"，"/packages/cards/Large/D菱形/7-7e507c2122efe10ed7abacab95edff97.png"]}，｛：name=>"4.满屋"，：value＝>
["/packages/cards/Large/Heart/T-3f8fd4fc3e09ec705a817aa212dc86.png"，"/packages/cards/Large/DDiamond/T-ef2fe11bbd701e4c5b6681e506271700.png"，"/packages/cards/Large/Spade/T-9a16f63a333b3edeb50c4372f8dd9883.png"，"/packages/cards/Large/Club/9-e6f0020a48aef9907b626477c5a60ac2.png"，"/packages/cards/Large/DDiamond/9-3e500833bafc81a708d195f16d005125.png"]}，｛：name=>"5.Flush"，：value＝>
["/packages/cards/Large/Spade/4-4200c8b5f3f5ba04d9fd5a69d71dab2f.png"，"/packages/cards/Large/Spade/J-fff29c49da8ca1f7a272c5ac83f51d06.png"，"/packages/cards/Large/Spade/8-60d335b08119f600c3ca02aa58fa902d.png"，"/packages/cards/Large/Spade/2-e2d1cee5fc0db0b709990036153d57906.png"，"/packages/cards/Large/Spade/9-b0d71e777375ceb3954156232f1f2d.png"]}，｛：name=>"6.直"，：value＝>
["/packages/cards/Large/Club/9-e6f0020a48aef9907b626477c5a60ac2.png"，"/packages/cards/Large/D菱形/8-6cd5b3025be0dd56cd52dfd2a49d922d.png"，"/packages/cards/Large/Spade/7-6c1d19e9c923f8e4773cf00d05e26d6.png"，"/packages/cards/Large/DDiamond/6-a0c0218210a1a6c4ec17e5ce17ee3d8.png"，"/packages/cards/Large/Heart/5-f498916a3011c2b7199e1c1008dbe330.png"]}，｛：name=>"7.三种"，：value＝>
["/packages/cards/Large/Club/7-56106625720208cc02c1107c91365eb37.png"，"/packages/cards/Large/D菱形/7-7e507c2122efe10ed7abacab95eddf97.png"，"/packages/cards/Large/Spade/7-6c1d19e9c923f8e4773cf00d05e26d6.png"，"/packages/cards/Large/Club/K-3e8312c33de4718943cd0276de8a16a1.png"，"/packages/cards/Large/D菱形/3-909f8b1571f834c774576c93eae26594.png"]}，｛：name=>"8.两对"，：value＝>
["/packages/cards/Large/Club/4-3a9251d25da1ea2BA49e69e94549aee.png"，"/packages/cards/Large/Spade/4-4200c8b5f3f5ba04d9fd5a69d71dab2f.png"，"/packages/cards/Large/Club/3-0c3eda54cfb6808b0a94950c045e497a.png"，"/packages/cards/Large/D菱形/3-909f8b1571f834c774576c93eae26594.png"，"/packages/cards/Large/Club/Q-9fcc4fd7692aa96ba9fcb04fa9fd727d.png"]}，｛：name=>"9.配对"，：value＝>
["/packages/cards/Large/Heart/A-748f3f87f79ac475e6a432750725b64c.png"，"/packages/cards/Large/D菱形/A-49a04aaeee96d2f948dc2062c4fcd5.png"，"/packages/cards/Large/Club/8-c3708e4821723f1100d514e5280b3f32.png"，"/packages/cards/Large/Spade/4-4200c8b5f3f5ba04d9fd5a69d71dab2f.png"，"/packages/cards/Large/Heart/7-1610ff3e74c68f6dd8a855bd16887457.png"]}，｛：name=>"10.高卡"，：value＝>
["/packages/cards/Large/D菱形/3-909f8b1571f834c774576c93eae26594.png"，"/packages/cards/Large/Club/J-58b4c0f26e3e0cf8c0772ab3e9e34784.png"，"/packages/cards/Large/Spade/8-60d335b08119f600c3ca02aa58fa902d.png"，"/packages/cards/Large/Heart/4-712ce04b7f2c7e588c48a1e2b46a2444.png"，"/packages/cards/Large/Spade/2-e2d1cee5fc0db0b709990036153d57906.png"]}]

希望它能有所帮助：)

Answer 2

doc.css('div#rules-of-poker-accordion')调用返回一个div，这就是页面的结构。因此，您实际上只进入each循环一次。

该网站的布局有点有趣，所以你必须分别获得名称和值。这是一个暴力解决方案。。。

def get_all_hands
doc = Nokogiri::HTML(open('http://www.cardplayer.com/rules-of-poker/hand-rankings'))
hands_array = []
doc.css('div#rules-of-poker-accordion').css("strong").each do |name|
hands_array.push({name: name.text, value: []})
end
doc.css('div#rules-of-poker-accordion').css(".rules-cards").each_with_index do |hand, i|
hand.css('img').each do |card|
hands_array[i][:value].push card.attr('src')
end
end
hands_array
end

Answer 3

@kiddorails的答案是正确的，但在这个问题上你可以更加简洁和Ruby惯用。考虑以下给出相同结果：

def get_all_hands
doc = Nokogiri::HTML(open('http://www.cardplayer.com/rules-of-poker/hand-rankings'))
hands = doc.css('div#rules-of-poker-accordion').first
hands.css('strong').zip(hands.css('div.rules-cards')).map do |hand, value|
{name: hand.text, value: value.css('img').map { |card| card.attr('src') }}
end
end

Ruby有强大的方法来处理和转换数组。一旦您有了一个数组，您就可以使用Ruby的许多可表达枚举方法之一对其进行转换@kiddorails从使用#zip将两个数组连接在一起开始，上面的重构通过使用#map将生成的数组转换为哈希数组来完成任务。

在Ruby中，只要你发现自己在写这个模式：

result = []
array.each { |element| result << method(element) }
result

您通常可以将这三行替换为：

array.map { |element| method(element) }