C语言 与链表未对齐的地址内的成员访问



所以我正在解决leetcode的第2个问题(基本上你在列表中颠倒了2个数字,需要将它们相加并在倒置列表中返回答案(。但是,我不断收到这个烦人的错误:"运行时错误:类型'struct ListNode'的地址0x000000000031未对齐的成员访问,这需要 8 字节对齐"。我在我的机器上运行它,它工作正常,给出了预期的结果。我的代码:

/*Definition of the list:
struct ListNode {
int val;
struct ListNode* next;
};*/
struct ListNode* addTwoNumbers(struct ListNode* l1, struct ListNode* l2) {
struct ListNode* answer = malloc(sizeof(struct ListNode));
answer->next = NULL;
answer->val = 0;
int auxInt = 0;
struct ListNode* auxVar = answer;
while(l1 != NULL || l2 != NULL) {
if(!l1) {
auxInt = answer->val;
answer->val = (auxInt + l2->val) % 10;
if(((l2->val + auxInt) / 10) != 0) {
answer->next = malloc(sizeof(struct ListNode));
answer->next->val = (l2->val + auxInt) /10;
}
l2 = l2->next;
}
else if(!l2) {
auxInt = answer->val;
answer->val = (auxInt + l1->val) % 10;
if(((l1->val + auxInt) / 10) != 0) {
answer->next = malloc(sizeof(struct ListNode));
answer->next->val = (l1->val + auxInt) /10;
}
l1 = l1->next;
} else {
auxInt = answer->val;
answer->val = (l1->val + l2->val + auxInt) % 10;
if(((l1->val + l2->val + auxInt) / 10) != 0) {
answer->next = malloc(sizeof(struct ListNode));
answer->next->val = (l1->val + l2->val + auxInt) /10;
}
l1 = l1->next;
l2 = l2->next;
}
if(l1 == NULL && l2 == NULL)
break;
else
{
if(!answer->next)
answer->next = malloc(sizeof(struct ListNode));
answer = answer->next;
answer->next = NULL;
}
}
return auxVar;
}

关于可能导致此问题的原因的任何想法?谢谢你的时间。

编辑:这是一个可验证的示例,其中包含导致崩溃的数字:

#include <stdio.h>
#include <stdlib.h>
struct ListNode {
int val;
struct ListNode *next;
};
/*typedef struct InvertedList {
int val;
struct InvertedList *next;
struct InvertedList *previous;
}Lista;*/
struct ListNode* addTwoNumbers(struct ListNode* l1, struct ListNode* l2) {
struct ListNode* answer = malloc(sizeof(struct ListNode));
answer->next = NULL;
answer->val = 0;
int auxInt = 0;
struct ListNode* auxVar = answer;
while(l1 != NULL || l2 != NULL) {
if(!l1) {
auxInt = answer->val;
answer->val = (auxInt + l2->val) % 10;
if(((l2->val + auxInt) / 10) != 0) {
answer->next = malloc(sizeof(struct ListNode));
answer->next->val = (l2->val + auxInt) /10;
}
l2 = l2->next;
}
else if(!l2) {
auxInt = answer->val;
answer->val = (auxInt + l1->val) % 10;
if(((l1->val + auxInt) / 10) != 0) {
answer->next = malloc(sizeof(struct ListNode));
answer->next->val = (l1->val + auxInt) /10;
}
l1 = l1->next;
} else {
auxInt = answer->val;
answer->val = (l1->val + l2->val + auxInt) % 10;
if(((l1->val + l2->val + auxInt) / 10) != 0) {
answer->next = malloc(sizeof(struct ListNode));
answer->next->val = (l1->val + l2->val + auxInt) /10;
}
l1 = l1->next;
l2 = l2->next;
}
if(l1 == NULL && l2 == NULL)
break;
else
{
if(!answer->next)
answer->next = malloc(sizeof(struct ListNode));
answer = answer->next;
}
}
return auxVar;
}
void adicionaLista(struct ListNode* ptrLista, char *array, int size) {
struct ListNode *auxNode = ptrLista;
for(int i = 0; i < size; i++) {
ptrLista->val = array[i];
if(i + 1 != size) {
ptrLista->next = malloc(sizeof(struct ListNode));
ptrLista = ptrLista->next;
}
}
ptrLista = auxNode;
printf("n");
}
void printAnswer(struct ListNode *ptrAnswer) {
for(; ptrAnswer != NULL; ptrAnswer = ptrAnswer->next)
printf("%d ", ptrAnswer->val);
}
int main()
{
struct ListNode *l1 = malloc(sizeof(struct ListNode));
struct ListNode *l2 = malloc(sizeof(struct ListNode));
char lista[9] = {4,5,2,2,9,3,8,9,2};
char lista2[9] = {0,7,6,1,6,5,0,6,7};
adicionaLista(l1, lista, 9);
adicionaLista(l2, lista2, 9);
struct ListNode *answer = addTwoNumbers(l1, l2);
printAnswer(answer);
return 0;
} 

主要问题是最后一个元素中的next未设置为NULL
次要问题是...

  1. 预计不会创建空列表,即创建无用节点的情况。
  2. 代码中有许多重复项。这使得更改代码变得困难。
  3. printf("n");不应包含在数据的附加功能中。它应该在输出函数中使用。

固定和减少代码

#include <stdio.h>
#include <stdlib.h>
struct ListNode {
int val;
struct ListNode *next;
};
struct ListNode *addTwoNumbers(struct ListNode *l1, struct ListNode *l2) {
struct ListNode anchor  = { .next = NULL }, *curr = &anchor;
int carry = 0;
while(l1 != NULL || l2 != NULL || carry) {
int val1 = 0, val2 = 0;
if(l1) {
val1 = l1->val;
l1 = l1->next;
}
if(l2) {
val2 = l2->val;
l2 = l2->next;
}
int answer = val1 + val2 + carry;
carry = answer > 9;//val1 and val2 are one digit.
curr = curr->next = malloc(sizeof(struct ListNode));
curr->val = answer % 10;
curr->next = NULL;
}
return anchor.next;
}
struct ListNode *makeListFromChars(const char *array, int size) {
struct ListNode anchor  = { .next = NULL }, *curr = &anchor;
for(int i = 0; i < size; i++) {
curr = curr->next = malloc(sizeof(struct ListNode));//Creating lists and adding data is a separate function.
curr->val = array[i];
curr->next = NULL;
}
return anchor.next;
}
void printList(struct ListNode *p) {
for(; p; p = p->next)
printf("%d ", p->val);
printf("n");
}
int main(void){
char lista1[9] = {4,5,2,2,9,3,8,9,2};
char lista2[9] = {0,7,6,1,6,5,0,6,7};
struct ListNode *l1 = makeListFromChars(lista1, 9);
struct ListNode *l2 = makeListFromChars(lista2, 9);
printList(l1);
printList(l2);
struct ListNode *answer = addTwoNumbers(l1, l2);
printList(answer);
//freeList(l1);freeList(l2);freeList(answer);
return 0;
} 

相关内容

  • 没有找到相关文章

最新更新