Groovy Spock:如何在不抛出错误的情况下将new Exception传递给when方法? &

Question

我正在尝试测试一个kafka错误处理程序，它接受一个Exception，但一旦我在spock中声明它，它实际上抛出它。

def 'test example'() {
when:
service.emitError(new Exception('test exception'))
then:
// do some tests
}

我已经尝试在包装的java类中声明它并在main中运行它不会抛出错误，但如果我将它拉入spock，它将错误地处理它。

我想看看我是否做错了，或者我是否不能用spock测试这个。

Answer 1

在Jeff的帮助下，我意识到这是一个模拟kafka模板的错误。当您必须将异常传递给模拟(不确定它是否只是特定于KafkaTemplate)并且预期的模拟失败时，会出现一些气泡，而我的try catch捕获了它。我意识到我应该发布原始代码——将来也会这样做。这是对没有测试(不是TTD)的预重构代码的测试

我错过了.key('key')，这是失败的

public class KafkaErrorNotificationEmitter {
private final KafkaTemplate<String, TopicMessageData> kafkaTemplate;
private final ObjectMapper objectMapper;
private final TemporalConfig.TimeKeeper timeKeeper;
private final String internalErrorTopic;
public KafkaErrorNotificationEmitter(
KafkaTemplate<String, TopicMessageData> kafkaTemplate,
ObjectMapper objectMapper,
TemporalConfig.TimeKeeper timeKeeper,
@Value("${kafka.error.topic}") String internalErrorTopic
) {
this.kafkaTemplate = kafkaTemplate;
this.objectMapper = objectMapper;
this.timeKeeper = timeKeeper;
this.internalErrorTopic = internalErrorTopic;
}
public void emitError(@Nullable KesMessageProperties kesMessageProperties, Exception ex) {
assert kesMessageProperties != null;
String entityName = kesMessageProperties.getEntityName();
log.warn("Failed message ({}). Sending to KES.", entityName, ex);
String key = kesMessageProperties.getMessage().getKey();
try {
TopicMessageData errorMessage =
TopicMessageData
.builder()
.sourceTopic(kesMessageProperties.getTopic())
.exceptionMessage(ex.getMessage())
.key(key)
.listenerType(kesMessageProperties.getListenerType())
.occurrenceTime(timeKeeper.nowZdt())
.payload(objectMapper.writeValueAsString(kesMessageProperties.getMessage()))
.build();
sendEmitError(errorMessage);
} catch (Exception e) {
log.error("Failed to send error ({}) notification for {}", entityName, key, e);
}
}
private void sendEmitError(final TopicMessageData topicMessageData) {
log.debug("Sending error message for: {}", topicMessageData);
kafkaTemplate.send(internalErrorTopic, topicMessageData);
}
}

class KafkaErrorNotificationEmitterSpec extends Specification {
KafkaTemplate<String, TopicMessageData> kafkaTemplate = Mock()
ObjectMapper objectMapper = new ObjectMapper()
TemporalConfig.TimeKeeper timeKeeper = Mock()
String internalErrorTopic = 'kes.error.test'
def kafkaErrorNotificationEmitter = new KafkaErrorNotificationEmitter(
kafkaTemplate,
objectMapper,
timeKeeper,
internalErrorTopic
)
@Shared
def errorMessage = 'Test exception'
@Shared
Exception exception = new Exception(errorMessage)
def 'emitError throws uncaught NPE'() {
setup:
def properties = new KesMessageProperties(message: null)
when:
kafkaErrorNotificationEmitter.emitError(properties, exception)
then:
0 * _
thrown NullPointerException
}
def 'emitError throws caught exception'() {
setup:
def properties = new KesMessageProperties(
message: new IKafkaMessage() {
@Override
String getKey() {
return null
}
}
)
when:
kafkaErrorNotificationEmitter.emitError(properties, exception)
then:
1 * timeKeeper.nowZdt() >> { throw new RuntimeException() }
0 * _
}
def 'emitError success'() {
setup:
def listenerType = 'test-error'
def properties = new KesMessageProperties(
listenerType: listenerType,
message: new IKafkaMessage() {
@Override
String getKey() {
return 'key'
}
}
)
def now = ZonedDateTime.now()
def errorData =
TopicMessageData
.builder()
.exceptionMessage(errorMessage)
.listenerType(listenerType)
//.key('key') // this is what was missing!!!
.occurrenceTime(now)
.payload('{"key":"key"}')
.build()
when:
kafkaErrorNotificationEmitter.emitError(properties, exception)
then:
1 * timeKeeper.nowZdt() >> now
1 * kafkaTemplate.send(internalErrorTopic, errorData) >> Mock(ListenableFuture)
}
}